Skip to content

Rearrange protobuf files #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2019
Merged

Rearrange protobuf files #251

merged 8 commits into from
Jun 17, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 14, 2019

I've decided to be conservative and reduce the impact of the layout at the bare minimum, we can iterate later should we need to. For now, this PR will:

  • rearrange protobuf files in a future-proof manner, grouping by service (only commands for now)
  • introduce a Task to run protoc, the task is run in the CI to ensure we don't commit wrong .proto files
  • move daemon under commands for consistency
  • make use of the gRPC client by turning it into a test that can be manually executed against a running CLI daemon using Task

@arduino arduino deleted a comment from ArduinoBot Jun 14, 2019
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-76-PR251-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-76-PR251-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-76-PR251-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-76-PR251-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-76-PR251-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@arduino arduino deleted a comment from ArduinoBot Jun 14, 2019
@arduino arduino deleted a comment from ArduinoBot Jun 14, 2019
@arduino arduino deleted a comment from ArduinoBot Jun 14, 2019
rsora
rsora approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit c2d9c1b into master Jun 17, 2019
@masci masci deleted the massi/layout-refact branch June 17, 2019 16:16
mastrolinux pushed a commit that referenced this pull request Jul 16, 2019
@masci
Rearrange protobuf files (#251)
806b690 
* move protobuf definitions under rpc/commands

* move commands daemon into commands folder

* make client a test case

* run protoc as part of the testing pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @ArduinoBot @rsora